Skip to content

update edge doc #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

alaahong
Copy link
Member

@alaahong alaahong commented Feb 3, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Improved translation of Edge-specific WebDriver documentation to Chinese.

  • Enhanced clarity and consistency in terminology and phrasing.

  • Updated formatting and examples for better readability.

  • Added detailed explanations for parameters and features.


Changes walkthrough 📝

Relevant files
Documentation
edge.zh-cn.md
Enhanced Chinese translation and formatting for Edge WebDriver
documentation

website_and_docs/content/documentation/webdriver/browsers/edge.zh-cn.md

  • Improved translation consistency and terminology usage.
  • Enhanced explanations for parameters like args, binary, and
    extensions.
  • Updated sections on logging, network conditions, and special features.
  • Refined formatting for better readability and clarity.
  • +80/-74 

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented Feb 3, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 79a9d94

    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 3, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Broken Link

    The '[Chrome DevTools]' link at the end of the document appears to be a broken/incomplete link without proper reference

    有关在 Edge 中使用 DevTools 的更多信息, 请参阅 [Chrome DevTools] 部分.

    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 3, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    ✅ Fix broken documentation link

    Fix the broken link reference to Chrome DevTools at the end of the document. The
    link is not properly formatted and will not work as intended.

    website_and_docs/content/documentation/webdriver/browsers/edge.zh-cn.md [475]

    -有关在 Edge 中使用 DevTools 的更多信息, 请参阅 [Chrome DevTools] 部分.
    +有关在 Edge 中使用 DevTools 的更多信息, 请参阅 [Chrome DevTools]({{< ref "../drivers/devtools.md" >}}) 部分.

    [Suggestion has been applied]

    Suggestion importance[1-10]: 8

    Why: The suggestion fixes a broken documentation link that would prevent users from accessing the Chrome DevTools reference. Proper linking is crucial for documentation usability and navigation.

    8

    @alaahong alaahong force-pushed the feature/edge_20250203 branch from 270f320 to 79a9d94 Compare February 3, 2025 08:56
    @alaahong alaahong merged commit b40a1f8 into SeleniumHQ:trunk Feb 3, 2025
    5 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant