Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] remove arabic workaround #2218

Merged
merged 2 commits into from
Mar 16, 2025
Merged

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Mar 12, 2025

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

https://www.selenium.dev/documentation/webdriver/browsers has a note about workaround for Arabic language formatting which is no longer needed as SeleniumHQ/selenium#15121 fixes the issue.

This note has to be removed now.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation


Description

  • Removed outdated note about Arabic language workaround.

  • Updated browser documentation to reflect recent fixes.


Changes walkthrough 📝

Relevant files
Documentation
_index.en.md
Remove outdated Arabic language workaround note                   

website_and_docs/content/documentation/webdriver/browsers/_index.en.md

  • Removed note about JVM localization settings for Arabic.
  • Updated documentation to reflect resolved startup issue.
  • +0/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented Mar 12, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 865c356

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Mar 12, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @Delta456 !

    @harsha509
    Copy link
    Member

    note is no longer needed as SeleniumHQ/selenium#15121 fixes the issue !

    @harsha509 harsha509 merged commit 57164ef into SeleniumHQ:trunk Mar 16, 2025
    3 checks passed
    @Delta456 Delta456 deleted the arab_rm branch March 16, 2025 15:33
    selenium-ci added a commit that referenced this pull request Mar 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants