-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Explain how Firefox uses user profiles #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain how Firefox uses user profiles #2262
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
51c8d4a
to
35311c0
Compare
Thanks for the PR! Could you please add this to each translation? |
Just a small note.. this not only happens when you reuse an existing profile, but also if you use |
@shbenzer You mean just adding the content in English? I don't speak those languages so wouldn't be able to translate them. If I add them in English, would they be picked up by a translator? I only updated the zh-cn version because I saw it was also in English:) |
35311c0
to
7f3afa9
Compare
The way the translations currently work is that we put all the information in English on each of the translations and one of our translators will go through and update it with the translation. |
This extends the Firefox profile documentation by explaining how Selenium works when supplying an existing profile directory. Since profiles are not cleaned up by Selenium, it also describes how they can be explicitly removed by the user.
7f3afa9
to
6a822b2
Compare
Should be ready for review again |
This looks good to me... but I don't have merge access in this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Ozoniuss !
Thank you @shbenzer , @cgoldberg , @titusfortner for the review! |
Congratulations on you first contribution to Selenium Docs @Ozoniuss 🎉 🎉 🎉 ! |
This extends the Firefox profile documentation by explaining how Selenium works when supplying an existing profile directory. Since profiles are not cleaned up by Selenium, it also describes how they can be explicitly removed by the user. Co-authored-by: Sri Harsha <[email protected]> 8945c9e
User description
Description
This extends the Firefox profile documentation by explaining how Selenium works when supplying an existing profile directory. Since profiles are not cleaned up by Selenium, it also describes how they can be explicitly removed by the user.
Note that I think that rather than telling the user to look up the code on how to find the exposed profile path, it may be more appropriate to provide code samples on how to delete it (in addition to code samples on how to use an existing profile, which I didn't find). I may do a PR for that (including moving from the inline code samples), but since I have to test it in several langauges including some I never worked it, it would take a while.
Motivation and Context
While developing and debugging my application, I ran out of space on my system because I was using a large profile, and it took a while to figure out where exactly the problem was.
Types of changes
Checklist
PR Type
Documentation
Description
Added explanation on using existing Firefox profiles in Selenium.
Highlighted that Selenium does not clean up profile copies.
Provided instructions for explicitly removing profile copies.
Linked to official Firefox documentation for profile directory guidance.
Changes walkthrough 📝
firefox.en.md
Added Firefox profile usage and cleanup details (English)
website_and_docs/content/documentation/webdriver/browsers/firefox.en.md
firefox.zh-cn.md
Added Firefox profile usage and cleanup details (Chinese)
website_and_docs/content/documentation/webdriver/browsers/firefox.zh-cn.md