-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test_chrome.py #2263
Update test_chrome.py #2263
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
HI @kimchi010 , Thanks for your PR. It looks like the entire Chrome test suite has been replaced. Could you please clarify the intention behind these changes? Since it significantly impacts our tests without clear context, I'm closing this PR for now. Please open an issue or submit a revised PR with the rationale if needed. Thanks, |
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Other
Description
Removed all existing test cases in
test_chrome.py
.Added a simplified script for simulating fake invites.
Introduced a basic
webdriver.Chrome
usage example.Changes walkthrough 📝
test_chrome.py
Replaced test cases with a simplified script
examples/python/tests/browsers/test_chrome.py
webdriver.Chrome
usage with minimal setup.