-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Updates for installing selenium libraries #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for jovial-austin-42fe02 ready! 🔨 Explore the source changes: d5b9395 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61afc7d771b21b0008a060da 😎 Browse the preview: https://deploy-preview-824--jovial-austin-42fe02.netlify.app |
a02bbf0
to
6ea5231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a sentence on top of the page saying "Check the downloads page to see what is the latest version?", since we are using 4.0.0
in the examples.
Also, could you please replace the content of the translated pages and add a notification on top asking for translation contributions?
website_and_docs/content/documentation/getting_started/installing_selenium_libraries.en.md
Outdated
Show resolved
Hide resolved
c343a99
to
00df658
Compare
Made the change, but rebased off of #861, so moving this to draft until that's merged. |
f71493f
to
60b6bb1
Compare
60b6bb1
to
6596550
Compare
@@ -2,6 +2,7 @@ | |||
title: "Instalando bibliotecas do Selenium" | |||
linkTitle: "Instalando bibliotecas do Selenium" | |||
weight: 1 | |||
needsTranslation: true | |||
description: > | |||
Setting up the Selenium library for your favourite programming language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configurando a biblioteca Selenium para sua linguagem de programção favorita
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translation to portuguese from the "Setting up the Selenium library for your favourite programming language."
This PR is in draft because it is just english for now, will update others after this approved.
This also brings up the consideration of how do we flag the non-English versions for being out of date with English versions? Updating the code is easy, but do we just leave the text alone?
This PR:
selenium-java
, I've seen too many poms that require different things in different places that have gotten out of sync on versions, and I don't see any advantage to this for novice users.