Skip to content

Updates for installing selenium libraries #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Updates for installing selenium libraries #824

merged 3 commits into from
Dec 7, 2021

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Nov 1, 2021

This PR is in draft because it is just english for now, will update others after this approved.

This also brings up the consideration of how do we flag the non-English versions for being out of date with English versions? Updating the code is easy, but do we just leave the text alone?

This PR:

  1. For simplicity I think we should always recommend users require the full selenium-java, I've seen too many poms that require different things in different places that have gotten out of sync on versions, and I don't see any advantage to this for novice users.
  2. Added Gradle example

@titusfortner titusfortner requested a review from diemol November 1, 2021 20:07
@netlify
Copy link

netlify bot commented Nov 1, 2021

✔️ Deploy Preview for jovial-austin-42fe02 ready!

🔨 Explore the source changes: d5b9395

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-austin-42fe02/deploys/61afc7d771b21b0008a060da

😎 Browse the preview: https://deploy-preview-824--jovial-austin-42fe02.netlify.app

@titusfortner titusfortner changed the title WIP: change references from seleniumhq.github.io to selenium.dev Updates for installing selenium libraries Nov 2, 2021
@diemol diemol marked this pull request as ready for review December 6, 2021 11:57
diemol
diemol previously requested changes Dec 6, 2021
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a sentence on top of the page saying "Check the downloads page to see what is the latest version?", since we are using 4.0.0 in the examples.

Also, could you please replace the content of the translated pages and add a notification on top asking for translation contributions?

@titusfortner
Copy link
Member Author

Made the change, but rebased off of #861, so moving this to draft until that's merged.

@titusfortner titusfortner marked this pull request as draft December 6, 2021 21:53
@titusfortner titusfortner marked this pull request as ready for review December 7, 2021 15:35
@titusfortner titusfortner requested a review from diemol December 7, 2021 15:35
@diemol diemol merged commit 5001179 into dev Dec 7, 2021
@diemol diemol deleted the installing_lib branch December 7, 2021 20:53
@@ -2,6 +2,7 @@
title: "Instalando bibliotecas do Selenium"
linkTitle: "Instalando bibliotecas do Selenium"
weight: 1
needsTranslation: true
description: >
Setting up the Selenium library for your favourite programming language.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configurando a biblioteca Selenium para sua linguagem de programção favorita

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation to portuguese from the "Setting up the Selenium library for your favourite programming language."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants