-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update legacy component APIs to the v1 API #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/cc @jamiehill |
/cc @eanplatter I know you wanted to get in on this migration. Here is a superb place to do so. If you pickup work on any of these components (or resume work on the Card) I'll go ahead and spec out the API and we can hash it out. |
I'll make PR for |
It looks that I think about making |
Unbelievable, it's almost done ✌️ |
I know it! Very crazy amount of work. So proud to be a part of this community effort. 🎉 |
The closing of #551 checks the last box. Can we mark this issue as closed? |
Holy smokes, it is done! 🎉 |
Right now, many components still use className for all styling and behavior. Our v1 API, decided in #208, is more declarative. You can see it at play in the Divider, Label, and Dropdown components. As well as any completed task below.
The CONTRIBUTING.md guide details how to go about designing a component API. The Spec out the API section is of primary importance.
You can reference PR #262 as an example of how to upgrade a legacy component API to the v1 API. Below are the remaining legacy components APIs. Any PR to upgrade these components is much welcome.
Collections
Update Grid to v1 API #351 Gridfeat(Menu): Update to v1 API #382 Menufeat(Table): update to v1 API #451 TableElements
feat(Button): support all features, update to v1 API #295 ButtonContainer Component updated to v1 API #277 ContainerIcon Component updated to v1 API #343 IconImage Component updated to v1 API #280 Imagefeat(Input): update to v1 API #281 Inputfix(List): Update to v1 API #551 ListHeader Component updated to v1 API #278 HeaderSegment: update to v1 API #287 SegmentModulesModal: update to v1 API #379 ModalViewsItem: Update to v1 API #431 ItemUpdate Statistic to v1 API #334 StatisticIn addition to these component APIs, we're also removing jQuery and SUI JS from all components. You can see that work in #247.
The text was updated successfully, but these errors were encountered: