Item: Update to v1 API

[layershifter]

Finished

Update Item component to v1 API.

[layershifter]

@levithomason Item.Items was removed, what I must do with this?

[levithomason]

The deprecatedComponents export old names, but replace them with another component:

-export const Items = deprecateComponent('Items', 'Use "Item.Items" instead.', Item.Items)
+export const Items = deprecateComponent('Items', 'Use "Item.Group" instead.', Item.Group)

The last argument is the replacement component. In this case, it will now export Items but when you import { Items } from 'stardust' you will see the warning message and the returned component will be Item.Group.

[codecov-io]

Current coverage is 96.69% (diff: 100%)

Merging #431 into master will increase coverage by 0.52%

@@             master       #431   diff @@
==========================================
  Files            84         90     +6   
  Lines          1254       1300    +46   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1206       1257    +51   
+ Misses           48         43     -5   
  Partials          0          0          

Powered by Codecov. Last update 598f764...0d34c02

[layershifter]

@levithomason I have problem there.

1. I think I need use createImage factory, but will it pass props?
2. ItemImage doesn't have ui class by default. How we can deal with this?

[layershifter]

@levithomason, finished ✌️

Can be merged after issue will be solved and code review 😺

[levithomason]

Taking a look...

[levithomason]

I've added a ui prop (and tests) to Image to allow turning off the ui className:

<Image {...rest} as={ElementType} ui={false} />

This seems to solve the issue with the ui className simply. We may add this feature for all components, though for now it will just be on the Image.

[levithomason]

There are a couple warnings to solve, looks like we're spreading props we shouldn't be:

Warning: Failed prop type: Invalid prop `items[0].childKey` of type `number` supplied to `ItemGroup`, expected `string`.

Warning: Unknown prop `childKey` on <div> tag. Remove this prop from the element.
in ItemGroup

[layershifter]

Seems, it fixed 👍

[layershifter]

Stupid question. Why you used there '&&' instead of useKeyOnly? 🐰

[levithomason]

Stupid answer, whoops!

[levithomason]

Will merge/release once tests pass

[levithomason]

Released in v0.38.0, we're getting closer to v1 :D 🎉