chore(package): support for jsnext:main #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
feat/jsnext
branch
from
0a406d0 to
752b5a3
Compare
layershifter
commented
Jan 23, 2017
| "main": "dist/commonjs/index.js", | ||
| "module": "dist/es/index.js", |
There was a problem hiding this comment.
module field for Rollup
layershifter
force-pushed
the
feat/jsnext
branch
from
752b5a3 to
85c913b
Compare
Current coverage is 95.89% (diff: 100%)@@ master #1210 diff @@
==========================================
Files 879 879
Lines 4890 4891 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4689 4690 +1
Misses 201 201
Partials 0 0
|
|
Fixed lint issue. |
|
@davezuko would love your eyes here. |
|
Is there any harm in always using the Rest looks good. |
|
@davezuko You're right, plugin returned 😄 |
levithomason
approved these changes
Jan 24, 2017
47 tasks
|
Released in |
DomiR
added a commit
to DomiR/Semantic-UI-React
that referenced
this pull request
Jan 26, 2017
* Semantic-Org/master: (111 commits) fix(docs): fix usage of arrow function (Semantic-Org#1228) fix(Icon): Incorrect definition in typings (Semantic-Org#1225) fix(Button): fix `tabIndex` in typings (Semantic-Org#1224) fix(typings): add item prop to the DropdownProps (Semantic-Org#1223) docs(examples): add missing `key` props (Semantic-Org#1220) docs(changelog): update changelog [ci skip] 0.64.4 feat(Form): add `inverted` prop (Semantic-Org#1218) fix(ComponentExample): use explicit babel presets (Semantic-Org#1219) style(Button): update typings and propTypes usage (Semantic-Org#1216) style(Embed): update typings and propTypes usage (Semantic-Org#1217) chore(package): support for jsnext:main (Semantic-Org#1210) style(Step): update typings, tests and propTypes usage (Semantic-Org#1203) fix(Portal): do not take focus after first render (Semantic-Org#1215) style(Table|mixed): update typings, tests and propTypes usage (Semantic-Org#1200) fix(Dropdown): use `item` instead of `as={Menu.Item}` (Semantic-Org#659) fix(Dropdown): respect `closeOnBlur={false}` (Semantic-Org#1148) style(Breadcrumb): update typings and propTypes usage (Semantic-Org#1209) style(Dimmer): update typings (Semantic-Org#1208) fix(Divider|FormInput): fix the broken typings (Semantic-Org#1179) ...
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
* chore(package): support for jsnext:main * chore(package): lodash plugin goes back
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #862.
Webpack 2 was released, let's make happy its users 😄