feat(docs): restore enum expansion on docs page #1266
Conversation
Codecov Report@@ Coverage Diff @@
## master #1266 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 882 882
Lines 4917 4917
=======================================
Hits 4716 4716
Misses 201 201
Continue to review full report at Codecov.
|
| return SUI[parts[1]] | ||
| } else if (parts[1] === '_meta') { | ||
| // these look like Sidebar._meta.props.animation | ||
| return _.get(this.props, `meta.props.${parts[3]}`, value) |
There was a problem hiding this comment.
_meta.props is in the process of going away and the values are being inlined into the propTypes checkers, example. You can see progress here. Given this, we're removing all traces of _meta.props from the codebase.
In this case, we should probably just not parse the meta.props here at all, for now. Most the enums will show up automatically because the values can be parsed by react-docgen. Those that cannot will be those that have more complicated checkers, which, we'll have to solve another way.
levithomason
changed the title
|
Thanks! |
This restores the enum display in the docs lost by #731
To get it to work I'm now parsing the docgen to get the correct values which has it's limitations. docgen is very literal when it comes to programatic propTypes, so I've tried expanding the easy ones but there's a few occurrences that are more difficult to make work (see last screenshot for an example)
