style(Progress): refactor, update typings and remove propTypes #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Feb 1, 2017
| inverted, label, percent, precision, progress, size, success, total, value, warning, | ||
| } = props | ||
| /** | ||
| * A progress bar shows the progression of a task. |
This was referenced Feb 1, 2017
Codecov Report@@ Coverage Diff @@
## master #1269 +/- ##
=========================================
- Coverage 95.91% 95.9% -0.01%
=========================================
Files 882 882
Lines 4917 4914 -3
=========================================
- Hits 4716 4713 -3
Misses 201 201
Continue to review full report at Codecov.
|
|
Tests are passing, I looked it over, and I also pulled this branch down to try it out. Looks great, let's merge and see how we did :) |
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.
This PR contains serious refactoring of component, need your review @levithomason