Update docs #220
Merged
Update docs #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
feature/update-docs
branch
2 times, most recently
from
bdbfb95 to
6f9c1c1
Compare
| @@ -1,68 +1,104 @@ | |||
| import _ from 'lodash' | |||
| import React, { Component, PropTypes } from 'react' | |||
| import SEMANTIC_TYPES from 'docs/app/utils/SemanticTypes' | |||
| import STARDUST_TYPES from 'docs/app/utils/StardustTypes' | |||
There was a problem hiding this comment.
cruft, these are not part of the _meta object and associated util.
levithomason
force-pushed
the
feature/update-docs
branch
from
6f9c1c1 to
015ffb7
Compare
| _.includes(LIBRARY_VALUES, _.get(_meta, 'library')) && | ||
| _.includes(TYPE_VALUES, _.get(_meta, 'type')) && | ||
| _.includes(NAME_VALUES, _.get(_meta, 'name')) | ||
| ) |
There was a problem hiding this comment.
We can now validate _meta objects. Meta is a static component prop, we need this below to identify / find the meta object from many possible sources.
| * Extract the Stardust _meta object and optional key. | ||
| * Handles literal _meta objects, classes with _meta, objects with _meta | ||
| * @private | ||
| * @param {string|function|object} arg A class, a component instance, or meta object.. |
There was a problem hiding this comment.
Should only be function | object, right?
There was a problem hiding this comment.
Right you are, thanks.
|
Don't see anything that sticks out to me, looks good so far. 👻 |
|
🐓 - looks like some great updates to the doc site |
levithomason
force-pushed
the
feature/update-docs
branch
from
015ffb7 to
e120207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a breakout of #206. Several issues were addressed:
Robust
_metautilShow
addonsin the sidebar.Show related components
Fix the sidebar filtering.
Blocked by
https://github.com/TechnologyAdvice/stardust/pull/221