Remove the Null type bound from CoregexInstances#Matching
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! 🙏 And congrats on being the first external contributor to this project. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging scala/scala3#17470 in 3.4.x and running Open Community Build we found out it is no longer compiling - build logs. However, the compiler team has decided that that reason for that is not a new regression, but rather typer improvement.
This change does not affect the Scala 3 LTS line (3.3.x) but would affect the users of Scala 3.4.x and later.
To allow for further testing this project in the Open Community Build and in the future to allow users of Scala 3.4.x to use this library I propose a temporary workaround which removes the unnecessary Null type bound.