Skip to content

Script parsing if file doesn't exist #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
Olyno opened this issue Dec 7, 2021 · 1 comment
Closed
1 task done

Script parsing if file doesn't exist #4459

Olyno opened this issue Dec 7, 2021 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@Olyno
Copy link
Contributor

Olyno commented Dec 7, 2021 •
edited
Loading

Skript/Server Version

Skript: 2.6
Spigot: 1.16.5

Bug Description

When (re)loading a script which doesn't exist, it throws function errors (this function already exists....)

Expected Behavior

We should have the "This script doesn't exist"

Steps to Reproduce

  • /skript reload myScript

Errors or Screenshots

See error: https://cdn.discordapp.com/attachments/917895984527327262/917895991359832095/unknown.png

Other

I guess the issue comes from this commit, nothing sure

Agreement

  • I have read the guidelines above and confirm I am following them with this report.

Reported by @janis4269
@AyhamAl-Ali
Copy link
Member

More info can be found in discord

@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Dec 15, 2021
APickledWalrus added a commit that referenced this issue Jun 17, 2022
@APickledWalrus
Use canonical form of files where necessary
a2d1540 
This should address issues like #4459
@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Jun 17, 2022
@APickledWalrus APickledWalrus mentioned this issue Jun 17, 2022
Merged
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TheLimeGlass @AyhamAl-Ali @Olyno @APickledWalrus @TPGamesNL