Skip to content

ComfyUI plugin #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

ComfyUI plugin #36

wants to merge 7 commits into from

Conversation

hlky
Copy link
Contributor

@hlky hlky commented May 20, 2023

Initial ComfyUI plugin implementation

Uses basic workflows for text-to-image, image-to-image, inpaint/outpaint

image

image

msedge_L0mWHAV00N

msedge_qbMLZvzvTt

msedge_lybZfwKaCT

  • Image count in UI set to value from plugin, image count != batch size, images are queued, seeds are incremental
  • Image strength default value configurable by plugin, also changed the default value because 100% image strength just returns the same image
    • Image strength is backwards to denoise in ComfyUI, e.g. denoise 1.0 is equivalent to Image strength 0%, 75% image strength is equivalent to 0.25 denoise

Note: Plugin UI extension support would be useful for additional features, something like this, just a quick implementation, not pushed for now because it could be done better, maybe the types could be the UI elements in Theme, definitions below would change "select" -> "Popout" and "boolean" -> "Checkbox"
image
image

TODO: lots

@browsertasker3094
Copy link

That is an amazing article.

@KAJdev KAJdev added help wanted We'd love some help! new feature This is a new feature! labels May 20, 2023
tocoro pushed a commit to tocoro/StableStudio that referenced this pull request May 20, 2023
* use tiktoken for api limit

* model conditional char limits on frontend

* adjust for completion tokens

---------

Co-authored-by: Alan Pogrebinschi <[email protected]>
@cruhl cruhl added the important We really care about this issue! label May 20, 2023
@cruhl cruhl assigned cruhl and hlky May 20, 2023
@cruhl
Copy link
Contributor

cruhl commented May 20, 2023

Really awesome work! I’ll be able to help get it merged after the weekend.

@hlky
Copy link
Contributor Author

hlky commented May 22, 2023

Let me know if there are any changes or anything to add for this initial version

@cruhl
Copy link
Contributor

cruhl commented May 23, 2023

@hlky We're considering moving out most plugins from this monorepo into separate repositories so you don't need our approval.

Beyond WebGPU + SDWebUI (which we have the capacity to support first-party), I'm afraid of @KAJdev and myself becoming a bottleneck.

We'd maintain a list of recommended plugins in this project linking out to efforts like this for maximum visibility.

How does that sound?

Open to suggestions/ideation here!

@cruhl
Copy link
Contributor

cruhl commented Jun 12, 2023

@hlky We're moving to ComfyUI for lots of things internally now, so it makes sense for this to be a first-party plugin.

Sorry for the whiplash!

Would you mind re-opening this PR? We are interested in having official ComfyUI support by June 22nd and would love to help get this done. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We'd love some help! important We really care about this issue! new feature This is a new feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants