Skip to content

Add plain option for target coverage #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2022

Conversation

rlalik
Copy link
Contributor

@rlalik rlalik commented May 6, 2022

When no visibility is specified for target, adding coverage with any of the two options: PUBLIC or INTERFACE (PRIVATE is default) results in error:

The plain signature for target_link_libraries has already been used with
the target "xxxxx".  All uses of target_link_libraries with a
target must be either all-keyword or all-plain.

where

target_link_libraries(xxxxx libA libB) # no visibility specified

I added PLAIN option which do not add any visibility, as the default option is always PRIVATE.

Alternatively, one should add PRIVATE option and leave no option equivalent to PLAIN but this will break back-compatibility, which might not be an issue perhaps. Actually this is what I would prefer Makes it more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants