Skip to content

clean up things that don't work in SL4 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2018
Merged

clean up things that don't work in SL4 #21

merged 3 commits into from
Mar 27, 2018

Conversation

braver
Copy link
Member

@braver braver commented Mar 25, 2018

No description provided.

@braver braver requested a review from kaste March 25, 2018 18:02
kaste
kaste requested changes Mar 25, 2018
View reviewed changes
Copy link
Contributor

@kaste kaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary annoying and breaking to cut the defaults here. Since they're all empty strings they don't do harm.

@braver braver merged commit c750da7 into master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaste kaste kaste approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braver @kaste