Skip to content

fix(migration): add internet access role for OIDC enabled jobs #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

fix(migration): add internet access role for OIDC enabled jobs #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbbf7dd
fix(migration): add internet access role for OIDC enabled jobs
guilhem-barthes May 26, 2025
fbf817a
fix: replace ingress by egress
guilhem-barthes May 30, 2025
afb33bf
feat: add doc & bump chart
guilhem-barthes May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/substra-backend/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Changelog

<!-- towncrier release notes start -->
## [26.15.3] - 2025-30-05

Allow OIDC connection to job-migration

## [26.15.2] - 2025-02-17

Inject OIDC config in migration job & bump app version to 1.0.1
Expand Down
2 changes: 1 addition & 1 deletion charts/substra-backend/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: substra-backend
home: https://github.com/Substra
version: 26.15.2
version: 26.15.3
appVersion: 1.0.1
kubeVersion: '>= 1.19.0-0'
description: Main package for Substra
Expand Down
4 changes: 4 additions & 0 deletions charts/substra-backend/templates/job-migrations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ spec:
labels:
{{ include "substra.labels" . | nindent 10 }}
role-database-client: 'true'
# If OIDC is enabled, we need to allow the job to access the internet to fetch the user info, as it is based on the user info.
{{- if .Values.oidc.enabled }}
role-internet-egress: 'true'
{{- end }}
spec:
restartPolicy: OnFailure
automountServiceAccountToken: false
Expand Down
Loading