Skip to content

Add content-length to $ignore #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lightxx opened this issue Mar 17, 2017 · 2 comments
Closed

Add content-length to $ignore #2

lightxx opened this issue Mar 17, 2017 · 2 comments
Assignees

Comments

@lightxx
Copy link

lightxx commented Mar 17, 2017

This is not really an issue but a feature request: cURL automatically sets the content-length header, so content-length should be stripped from the incoming request like all the other headers in $ignore

@lightxx
Copy link
Author

lightxx commented Mar 17, 2017

Background: I've extended your proxy class to include certain certificate information when proxying the request. Took me a while and wireshark to figure out the reason why the information never got to the proxied host, because the content-length was the 'old', pre-certificate information content-length. So the data was actually transmitted over the wire but ignored by the web server.

@Svish
Copy link
Owner

Svish commented Mar 19, 2017

That's a good point, and even counts as a bug I'd say.

Added the header to $ignore as you suggested. Committed and tagged v2.1.6 🙂

@Svish Svish closed this as completed Mar 19, 2017
@Svish Svish changed the title Feature Request: Add content-length to $ignore Add content-length to $ignore Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants