Skip to content

chore(docs): add spellcheck #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2021
Merged

chore(docs): add spellcheck #2466

merged 4 commits into from
Nov 17, 2021

Conversation

rokroskar
Copy link
Member

Adds spellcheck to the docs test.

@rokroskar rokroskar marked this pull request as ready for review November 17, 2021 08:19
@rokroskar rokroskar requested a review from a team as a code owner November 17, 2021 08:19
Panaetius
Panaetius previously approved these changes Nov 17, 2021
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tihs looks graet, tahnk you!

[edit]
I guess it's parametrization not parameterization

@rokroskar
Copy link
Member Author

😭

I think I fixed that one before?

@rokroskar
Copy link
Member Author

Ah no now I remember - that was the commit that made me open this PR in the first place because it broke the docs build in the renku repo 😄

Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aewsmoe!

@rokroskar
Copy link
Member Author

Aewsmoe!

This will no longer be tolerated around here @Panaetius! 🤣

@Panaetius
Copy link
Member

We'll, you should really just implement spellcheckng for commentsd and PR titles as well, as those'l end up in the changelog.

@rokroskar
Copy link
Member Author

I leave these maintainer tasks to the maintainers 😉

@rokroskar rokroskar merged commit 6780b59 into master Nov 17, 2021
@rokroskar rokroskar deleted the 000-add-spellcheck branch November 17, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants