-
Notifications
You must be signed in to change notification settings - Fork 25
chore: move to pyproject and poetry #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f17d46
to
cc3e002
Compare
6018ff5
to
e3efaaf
Compare
779294f
to
df3007b
Compare
df3007b
to
1af8f3c
Compare
1af8f3c
to
ef8e9af
Compare
90786fe
to
92d9c24
Compare
92d9c24
to
ef8f5b6
Compare
7fca3e7
to
3f7a350
Compare
For an example of the cache: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚀
closes #2405
Moves all configuration to pyproject.toml
Moves building/dependency management to poetry
Gets rid of setup.py
Updates Github Actions to work with poetry
Also:
Adds caching of python dependencies between runs in the github actions, to speed things up a bit (and reduce bandwidth)
Reduces exponential backoff in our
requests
wrapper so the worst case is not 17 minutes but 6seconds.Formatter the github actions to have consistent indent
Added some missing init.py (poetry threw warnings when building)
Note:
version.py.tmpl is gone,
poetry-dynamic-versioning
patches version.py directly.0.0.0
is just a placeholder. The way it works is that before apoetry build
orpoetry install
, it patches version.py with the correct version, and after in un-patches it again. This has the downside that the version locally is always 0.0.0, only renku installed in the env and published packages have the version actually set. I didn't notice any issues with running tests or commands with this, so I think it's fine.