[trait] remove annotation support for ResetPasswordRequest objects #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
commented
Apr 11, 2024
| @@ -26,21 +28,28 @@ public function testIsCompatibleWithInterface(): void | |||
|
|
|||
| public function propertyDataProvider(): \Generator | |||
| { | |||
| yield ['selector', '@ORM\Column(type="string", length=20)']; | |||
There was a problem hiding this comment.
these unit tests almost seem silly if we have a full stack test in the bundle.. if we dont - we should create one and remove these tests..
This reverts commit 5c1cfd3.
jrushlow
force-pushed
the
feature/remove-doctrine-annotations
branch
from
bb2ae21 to
24f26d7
Compare
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes doctrine annotations in the
ResetPasswordRequestTrait. As a result, attribute mapping is required when using the trait forResetPasswordRequestentities.adds property types for class properties
add the
voidreturn type toinitialize()replaces annotations added to 1.x in [1.x] [trait] add type annotations to
ResetPasswordRequestTrait#305app test locally