Skip to content

remove null from optional field type union #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

Alexendoo
Copy link

Messages with optional fields will now implement their corresponding
interfaces (IMessage)

fixes protobufjs#834
fixes protobufjs#837

as requested in protobufjs#844

Messages with optional fields will now implement their corresponding
interfaces (IMessage)

fixes protobufjs#834
fixes protobufjs#837
@Szpadel Szpadel merged commit 78d027b into Szpadel:master Jul 26, 2017
@Szpadel
Copy link
Owner

Szpadel commented Jul 26, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated TypeScript message class not compatible with generated message interface Generated typescript file is not usable anymore
2 participants