Skip to content

chore: Downgrade Nx to v17.3.1 #6830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2024
Merged

chore: Downgrade Nx to v17.3.1 #6830

merged 1 commit into from
Feb 4, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Feb 4, 2024

Some bug is impairing detection of target scripts in v17.3.2. Only project.json scripts were recognised. I can't replicate this in the tanstack/config or tanstack/form repos.

I've removed scripts/project.json since the actual publish script we were linting has been moved into tanstack/config, and it gave false confidence that Nx was working.

Bug is impairing detection of target scripts
Copy link

vercel bot commented Feb 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
query ⬜️ Ignored (Inspect) Feb 4, 2024 2:55am

Copy link

nx-cloud bot commented Feb 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 104d22e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codesandbox-ci bot commented Feb 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 104d22e:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@lachlancollins lachlancollins merged commit caa2916 into main Feb 4, 2024
@lachlancollins lachlancollins deleted the fix-nx branch February 4, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant