Skip to content

Unhandled exception when JS exception is thrown #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dustinsoftware opened this issue Aug 22, 2018 · 3 comments
Closed

Unhandled exception when JS exception is thrown #59

dustinsoftware opened this issue Aug 22, 2018 · 3 comments

Comments

@dustinsoftware
Copy link

dustinsoftware commented Aug 22, 2018

A teammate got a crash when an exception was thrown. Unfortunately I do not have a repro for this.

Unhandled Exception: System.ArgumentOutOfRangeException: Index and length must refer to a location within the string. 
Parameter name: length
 at System.String.Substring(Int32 startIndex, Int32 length)
 at JavaScriptEngineSwitcher.Core.Helpers.JsErrorHelpers.GetSourceFragment(String source, Int32 position, Int32 length, Int32 columnNumber, Int32 maxFragmentLength)
 at JavaScriptEngineSwitcher.Core.Helpers.JsErrorHelpers.GetSourceFragmentFromLine(String sourceLine, Int32 columnNumber, Int32 maxFragmentLength)
 at JavaScriptEngineSwitcher.ChakraCore.ChakraCoreJsEngine.WrapJsException(JsException originalException, String defaultDocumentName)
 at JavaScriptEngineSwitcher.ChakraCore.ChakraCoreJsEngine.<>c__DisplayClass46_0.<InnerExecute>b__0()
 at JavaScriptEngineSwitcher.ChakraCore.ScriptDispatcher.<>c__DisplayClass11_0.<Invoke>b__0()
 at JavaScriptEngineSwitcher.ChakraCore.ScriptDispatcher.StartThread()

Current package versions

<package id="JavaScriptEngineSwitcher.ChakraCore" version="3.0.0-beta7" targetFramework="net47" />
<package id="JavaScriptEngineSwitcher.ChakraCore.Native.win-x64" version="2.4.22" targetFramework="net47" />
<package id="JavaScriptEngineSwitcher.Core" version="3.0.0-beta4" targetFramework="net47" />
@Taritsyn
Copy link
Owner

Hello, Dustin!

Thanks for information! I did not include, this fix in the official release because I have reached the beta numbering limit. I have published this fix as the JavaScriptEngineSwitcher.Core version 3.0.0 Beta 9 package. The next version will already have the status of release candidate.

@Taritsyn
Copy link
Owner

Hello, Dustin!

This error is fixed in version 3.0.0 RC 1.

@Taritsyn
Copy link
Owner

I close this issue because this error was fixed in release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants