Skip to content

Use stable toolchain for Actix #8812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

sebastienros
Copy link
Contributor

Fixes #8779

I have no idea how Rust is compiled and why this fixes it, but "nightly" didn't seem right for TFB, and it works, so ...

cc @robjtede

Proof:

[17:02:13 INF] Removing intermediate container 4956af1ad71d
[17:02:13 INF]  ---> 70f971b985b7
[17:02:13 INF] Step 7/8 : EXPOSE 8080
[17:02:13 INF]  ---> Running in 10ea344f34f6
[17:02:13 INF] Removing intermediate container 10ea344f34f6
[17:02:13 INF]  ---> bd6769491853
[17:02:13 INF] Step 8/8 : CMD ./target/release/tfb-web
[17:02:13 INF]  ---> Running in 71a0562abcd5
[17:02:13 INF] Removing intermediate container 71a0562abcd5
[17:02:13 INF]  ---> a72da117b2f9
[17:02:13 INF] Successfully built a72da117b2f9

On master:

[17:05:57 INF]    Compiling parking_lot v0.12.1
[17:05:57 INF] error[E0635]: unknown feature `stdsimd`
[17:05:57 INF]   --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.3/src/lib.rs:99:42
[17:05:57 INF]    |
[17:05:57 INF] 99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
[17:05:57 INF]    |                                          ^^^^^^^
[17:05:57 INF]
[17:05:57 INF] error[E0635]: unknown feature `stdsimd`
[17:05:57 INF]   --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.7.6/src/lib.rs:33:42
[17:05:57 INF]    |
[17:05:57 INF] 33 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
[17:05:57 INF]    |                                          ^^^^^^^
[17:05:57 INF]
[17:05:57 INF]    Compiling atty v0.2.14
[17:05:57 INF]    Compiling unicode-normalization v0.1.22
[17:05:57 INF]    Compiling rustls-pemfile v1.0.3
[17:05:57 INF]    Compiling rand_chacha v0.3.1
[17:05:57 INF]    Compiling take_mut v0.2.2
[17:05:57 INF]    Compiling termcolor v1.2.0
[17:05:57 INF]    Compiling humantime v2.1.0
[17:05:57 INF]    Compiling bitvec v1.0.1
[17:05:57 INF] For more information about this error, try `rustc --explain E0635`.
[17:05:57 INF] error: could not compile `ahash` (lib) due to 1 previous error
[17:05:57 INF] warning: build failed, waiting for other jobs to finish...
[17:05:57 INF] error: could not compile `ahash` (lib) due to 1 previous error
[17:05:57 INF] error: could not compile `ahash` (lib) due to 1 previous error
[17:06:08 INF] [STDERR] The command '/bin/sh -c RUSTFLAGS="-C target-cpu=native" cargo build --release' returned a non-zero code: 101

@sebastienros
Copy link
Contributor Author

sebastienros commented Mar 22, 2024

It's not even funny, after a few days working it's now failing even with stable and nightly also (with the same previous error). Here is the new one:

   Compiling askama_shared v0.12.2
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/simd-json-0.4.15/src/lib.rs:2:46
  |
2 | #![cfg_attr(target_feature = "neon", feature(stdsimd,))]
  |                                              ^^^^^^^

   Compiling actix-web-codegen v4.2.0
   Compiling yarte_parser v0.15.2
   Compiling bson v2.6.1
For more information about this error, try `rustc --explain E0554`.
error: could not compile `simd-json` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `simd-json` (lib) due to 1 previous error
The command '/bin/sh -c RUSTFLAGS="-C target-cpu=native" cargo build --release' returned a non-zero code: 101

@NateBrady23 NateBrady23 merged commit 46f68ae into TechEmpower:master Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants