Skip to content

update httpserver-robaho version #9418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 24, 2025
Merged

Conversation

robaho
Copy link
Contributor

@robaho robaho commented Nov 22, 2024

Updates to JDK 23 and version 1.0.22

@msmith-techempower
Copy link
Member

Closing - feel free to open a new PR when you resolve the conflicts.

@robaho
Copy link
Contributor Author

robaho commented Mar 17, 2025

There were no conflicts? Can you elaborate - this appears to be on the project side that wasn't able to pull the JDK23 release.

@msmith-techempower
Copy link
Member

There are merge conflicts that need to be resolved, and the last verify run log is no longer available.

I've reopened - please fix up the merge conflicts, and that will kick off a new verify run.

@robaho
Copy link
Contributor Author

robaho commented Mar 17, 2025

I am not what I can do here. There are no merge conflicts and the build is failing.

@robaho
Copy link
Contributor Author

robaho commented Mar 17, 2025

Maven says 23 is an invalid release - but I don’t think this is the case.

need different maven release for JDK23
@robaho
Copy link
Contributor Author

robaho commented Mar 19, 2025

The file is changed. Look at the commits. Not sure why the PR isn't showing the changes.

@msmith-techempower
Copy link
Member

I'm just not seeing that change committed.
image

@robaho
Copy link
Contributor Author

robaho commented Mar 19, 2025

If you click on robaho:master you will see it is in the commits, but I don't seem to have a way to refresh this PR.

@robaho
Copy link
Contributor Author

robaho commented Mar 19, 2025

It's there now - look at the changed files.

@msmith-techempower
Copy link
Member

Did a hard refresh - files changed still doesn't show it
image

@robaho
Copy link
Contributor Author

robaho commented Mar 19, 2025

so sorry, I was only review the first line, which is where this started. I apologize for wasting your time.

need to update the jdk from reference as well
@robaho
Copy link
Contributor Author

robaho commented Mar 19, 2025

I updated it, and it is still failing.

@msmith-techempower
Copy link
Member

It's because you updated the pom.xml to specify version 23, but you didn't update the other dockerfile to have the same changes.

update to 1.0.23
need to update other dockerfile
@msmith-techempower msmith-techempower merged commit c82a834 into TechEmpower:master Mar 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants