feat: added z_algorithm in strings #1581

RitikaGupta8734 · 2021-08-30T10:18:13Z

Description of Change

Added Z-Algorithm for pattern matching in strings.

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
PR title follows semantic commit guidelines
I acknowledge that all my contributions will be made under the project's license.

Notes:
Kindly review my PR and let me know any corrections.

RitikaGupta8734 · 2021-08-31T06:31:27Z

@Panquesito7 Kindly look into my PR.

ayaankhan98

please look at the contribution guidelines

RitikaGupta8734 · 2021-08-31T07:02:32Z

Hi @ayaankhan98 Can you be more specific where I made mistake. I am new to PR's.

strings/z_function.cpp

Updated z_function.cpp as per contribution guidelines. Fixed Link using github markdown syntax Created a separate function for tests and covered the corner case

Panquesito7

Great work! 😄👍

strings/z_function.cpp

More comments added to the code Co-authored-by: David Leal <[email protected]>

Some more documentation added as per contribution guidelines. Co-authored-by: David Leal <[email protected]>

comments added Co-authored-by: David Leal <[email protected]>

RitikaGupta8734 · 2021-09-01T04:27:12Z

Great work!

Thank you :)

Panquesito7

Please enable GitHub Actions in your repository of this fork in this link: https://github.com/RitikaGupta8734/C-Plus-Plus/actions

Panquesito7 · 2021-09-01T16:03:32Z

strings/z_function.cpp

+ * \returns a vector of starting indexes where pattern is found in the text 
+ */
+std::vector<int> find_pat_in_text(const std::string &pattern, const std::string &text) {
+    int text_length = text.size(), pattern_length = pattern.size();


Consider using uint64_t for non-negative values (or their appropriate size: uint32_t, uint16_t, uint8_t) or int64_t for negative values. Check other parts of the code (reference). 🙂

Made the required changes. Kindly review :)

strings/z_function.cpp

Co-authored-by: David Leal <[email protected]>

Updated int -> uint64_t for non-negative values

Panquesito7

Great work! Almost there. 😄

strings/z_function.cpp

Panquesito7 · 2021-09-02T03:22:22Z

strings/z_function.cpp

+    std::string text1 = "alskfjaldsabc1abc1abcbksbcdnsdabcabc";
+    std::string pattern1 = "abc";
+
+    std::vector<uint64_t> matching_indexes1 = find_pat_in_text(pattern1, text1);
+    assert((matching_indexes1 == std::vector<uint64_t>{10, 14, 18, 30, 33}));
+
+    // corner case
+    std::string text2 = "greengrass";
+    std::string pattern2 = "abc";
+
+    std::vector<uint64_t> matching_indexes2 = find_pat_in_text(pattern2, text2);
+    assert((matching_indexes2 == std::vector<uint64_t>{}));


Please add documentation of what this code is doing here. 🙂

Added comments for the same.

Co-authored-by: David Leal <[email protected]>

Panquesito7

Almost there! It's just to accept these suggestions, and you're done! 😄🎉

strings/z_function.cpp

Co-authored-by: David Leal <[email protected]>

Panquesito7

Awesome work, @RitikaGupta8734! It's been awesome for your first contribution here! We hope you keep contributing! 😄👍🎉

RitikaGupta8734 · 2021-09-03T17:34:00Z

Awesome work, @RitikaGupta8734! It's been awesome for your first contribution here! We hope you keep contributing!

Thanks a lot @Panquesito7 :)

RitikaGupta8734 · 2021-09-03T19:33:33Z

Hi @ayaankhan98 kindly review the PR again and let me know the feedback if any.

RitikaGupta8734 · 2021-09-04T06:49:41Z

Hi @Panquesito7 will my PR be merged?

ayaankhan98

LGTM 👍

RitikaGupta8734 · 2021-09-04T07:58:55Z

Thank You all ! :)

RitikaGupta8734 and others added 2 commits August 30, 2021 15:05

feat: added z_algorithm in strings

da4fb38

Merge branch 'master' into z-function

ecd65d5

ayaankhan98 requested changes Aug 31, 2021

View reviewed changes

ayaankhan98 reviewed Aug 31, 2021

View reviewed changes

strings/z_function.cpp Outdated Show resolved Hide resolved

ayaankhan98 reviewed Aug 31, 2021

View reviewed changes

strings/z_function.cpp Outdated Show resolved Hide resolved

Updated z_function.cpp

ad4dad5

Updated z_function.cpp as per contribution guidelines. Fixed Link using github markdown syntax Created a separate function for tests and covered the corner case

RitikaGupta8734 requested a review from ayaankhan98 August 31, 2021 07:43

Panquesito7 added enhancement New feature or request requested changes changes have been requested labels Sep 1, 2021

Panquesito7 requested changes Sep 1, 2021

View reviewed changes

RitikaGupta8734 and others added 3 commits September 1, 2021 09:48

Apply suggestions from code review

9addf17

More comments added to the code Co-authored-by: David Leal <[email protected]>

Apply suggestions from code review

757c109

Some more documentation added as per contribution guidelines. Co-authored-by: David Leal <[email protected]>

Update strings/z_function.cpp

b5cb054

comments added Co-authored-by: David Leal <[email protected]>

RitikaGupta8734 requested a review from Panquesito7 September 1, 2021 04:24

Panquesito7 requested changes Sep 1, 2021

View reviewed changes

RitikaGupta8734 and others added 3 commits September 2, 2021 01:03

Update strings/z_function.cpp

61cb76c

Co-authored-by: David Leal <[email protected]>

Merge branch 'master' into z-function

0c7515e

updating DIRECTORY.md

c212937

github-actions bot force-pushed the z-function branch from 0c7515e to d82a96f Compare September 1, 2021 19:34

clang-format and clang-tidy fixes for 0c7515e

edff958

github-actions bot force-pushed the z-function branch from d82a96f to edff958 Compare September 1, 2021 19:34

RitikaGupta8734 and others added 2 commits September 2, 2021 01:10

Updated int -> uint64_t

12d5123

Updated int -> uint64_t for non-negative values

clang-format and clang-tidy fixes for 12d5123

910cb68

RitikaGupta8734 requested a review from Panquesito7 September 1, 2021 19:42

Merge branch 'master' into z-function

96c64e5

Panquesito7 requested changes Sep 2, 2021

View reviewed changes

Update strings/z_function.cpp

0737aff

Co-authored-by: David Leal <[email protected]>

Update strings/z_function.cpp

c9919d6

Co-authored-by: David Leal <[email protected]>

github-actions bot force-pushed the z-function branch from c9919d6 to 0737aff Compare September 2, 2021 04:11

RitikaGupta8734 and others added 2 commits September 2, 2021 22:14

More comments added

8a627ac

clang-format and clang-tidy fixes for 8a627ac

02aae78

RitikaGupta8734 requested a review from Panquesito7 September 2, 2021 16:45

Panquesito7 reviewed Sep 2, 2021

View reviewed changes

strings/z_function.cpp Outdated Show resolved Hide resolved

strings/z_function.cpp Show resolved Hide resolved

strings/z_function.cpp Outdated Show resolved Hide resolved

RitikaGupta8734 and others added 2 commits September 3, 2021 12:05

Update strings/z_function.cpp

8ee1415

Co-authored-by: David Leal <[email protected]>

Update strings/z_function.cpp

88796b2

Co-authored-by: David Leal <[email protected]>

github-actions bot force-pushed the z-function branch from 88796b2 to 8ee1415 Compare September 3, 2021 06:36

RitikaGupta8734 requested a review from Panquesito7 September 3, 2021 06:37

Panquesito7 approved these changes Sep 3, 2021

View reviewed changes

Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Sep 3, 2021

Panquesito7 requested a review from mishraabhinn September 3, 2021 17:38

mishraabhinn approved these changes Sep 3, 2021

View reviewed changes

Merge branch 'master' into z-function

6198d6b

ayaankhan98 approved these changes Sep 4, 2021

View reviewed changes

ayaankhan98 merged commit b82e2cd into TheAlgorithms:master Sep 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added z_algorithm in strings #1581

feat: added z_algorithm in strings #1581

RitikaGupta8734 commented Aug 30, 2021 •

edited

Loading

RitikaGupta8734 commented Aug 31, 2021

ayaankhan98 left a comment

RitikaGupta8734 commented Aug 31, 2021 •

edited

Loading

Panquesito7 left a comment

RitikaGupta8734 commented Sep 1, 2021

Panquesito7 left a comment

Panquesito7 Sep 1, 2021

RitikaGupta8734 Sep 1, 2021

Panquesito7 left a comment

Panquesito7 Sep 2, 2021

RitikaGupta8734 Sep 2, 2021

Panquesito7 left a comment

Panquesito7 left a comment

RitikaGupta8734 commented Sep 3, 2021

RitikaGupta8734 commented Sep 3, 2021

RitikaGupta8734 commented Sep 4, 2021

ayaankhan98 left a comment

RitikaGupta8734 commented Sep 4, 2021

feat: added z_algorithm in strings #1581

feat: added z_algorithm in strings #1581

Conversation

RitikaGupta8734 commented Aug 30, 2021 • edited Loading

Description of Change

Checklist

RitikaGupta8734 commented Aug 31, 2021

ayaankhan98 left a comment

Choose a reason for hiding this comment

RitikaGupta8734 commented Aug 31, 2021 • edited Loading

Panquesito7 left a comment

Choose a reason for hiding this comment

RitikaGupta8734 commented Sep 1, 2021

Panquesito7 left a comment

Choose a reason for hiding this comment

Panquesito7 Sep 1, 2021

Choose a reason for hiding this comment

RitikaGupta8734 Sep 1, 2021

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

Panquesito7 Sep 2, 2021

Choose a reason for hiding this comment

RitikaGupta8734 Sep 2, 2021

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

RitikaGupta8734 commented Sep 3, 2021

RitikaGupta8734 commented Sep 3, 2021

RitikaGupta8734 commented Sep 4, 2021

ayaankhan98 left a comment

Choose a reason for hiding this comment

RitikaGupta8734 commented Sep 4, 2021

RitikaGupta8734 commented Aug 30, 2021 •

edited

Loading

RitikaGupta8734 commented Aug 31, 2021 •

edited

Loading