Skip to content

feat: add bisection method #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 5, 2023
Merged

feat: add bisection method #1233

merged 18 commits into from
Apr 5, 2023

Conversation

aybarsnazlica
Copy link
Contributor

Description of Change

Added bisection method used for root finding.

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

alexpantyukhin
alexpantyukhin reviewed Mar 15, 2023
View reviewed changes
alexpantyukhin
alexpantyukhin reviewed Mar 16, 2023
View reviewed changes
CascadingCascade
CascadingCascade reviewed Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@CascadingCascade CascadingCascade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest you to replace all float with double, more precision wouldn't hurt

alexpantyukhin
alexpantyukhin previously approved these changes Mar 17, 2023
View reviewed changes
CascadingCascade
CascadingCascade previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@CascadingCascade CascadingCascade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Panquesito7 Panquesito7 added the enhancement New feature or request label Mar 17, 2023
Panquesito7
Panquesito7 requested changes Mar 17, 2023
View reviewed changes
Panquesito7
Panquesito7 requested changes Mar 24, 2023
View reviewed changes
Panquesito7
Panquesito7 approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@Panquesito7 Panquesito7 merged commit a537cf3 into TheAlgorithms:master Apr 5, 2023
@aybarsnazlica aybarsnazlica deleted the bisection branch April 6, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpantyukhin alexpantyukhin alexpantyukhin approved these changes

@tjgurwara99 tjgurwara99 tjgurwara99 approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@CascadingCascade CascadingCascade CascadingCascade left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aybarsnazlica @alexpantyukhin @tjgurwara99 @Panquesito7 @CascadingCascade