Skip to content

feat: Added a program that prints words in alphabetical order using binary tree data structure #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 53 commits into from
Jul 30, 2021

Conversation

RandyKdev
Copy link
Contributor

@RandyKdev RandyKdev commented Jul 14, 2021

A program that reads words from a file and stores them in a binary tree where one word is a node in the tree with a frequency slot. The program then prints the words in alphabetical order together with their frequencies to a separate file

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: Implementation of sorting words in alphabetical order using Binary Tree Data Structure

@RandyKdev RandyKdev changed the title A program to prints words in alphabetical order using binary tree data structure feat: Added a program that prints words in alphabetical order using binary tree data structure Jul 15, 2021
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jul 17, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 😄👍
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/RandyKdev/C/actions

@RandyKdev
Copy link
Contributor Author

Great work!
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/RandyKdev/C/actions

Thanks for your time to review this. I am setting up github actions

@RandyKdev
Copy link
Contributor Author

Great work!
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/RandyKdev/C/actions

Thanks for your time to review this. I am setting up github actions

Github actions has been setup, successfully

@RandyKdev RandyKdev requested a review from Panquesito7 July 17, 2021 19:49
@RandyKdev RandyKdev requested a review from Panquesito7 July 19, 2021 07:10
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of functions and structures are missing documentation. Please add refined documentation according to our repository standards.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 😄👍

@RandyKdev RandyKdev requested a review from Panquesito7 July 27, 2021 22:11
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

@RandyKdev
Copy link
Contributor Author

RandyKdev commented Jul 29, 2021

Try not to accept the suggestions so quickly. Instead, accept one suggestion, wait a minute, and accept the next suggestion. There could be problems with the GitHub workflow removing those changes if you don't do it that way.

Ok, got it.
I would like to find out whether problems will arise with the Github workflow when suggestions are grouped and committed as a batch? and also when should '///<' and '//' be used for comments? Thanks.

@RandyKdev RandyKdev requested a review from Panquesito7 July 29, 2021 16:32
@RandyKdev RandyKdev requested a review from Panquesito7 July 29, 2021 18:23
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

@RandyKdev RandyKdev requested a review from Panquesito7 July 29, 2021 20:24
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; great work, @RandyKdev! All seems to be looking amazing! 😄👍🎉

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed Changes requested labels Jul 30, 2021
@ayaankhan98 ayaankhan98 merged commit 1b30b89 into TheAlgorithms:master Jul 30, 2021
@RandyKdev
Copy link
Contributor Author

RandyKdev commented Jul 30, 2021

LGTM; great work, @RandyKdev! All seems to be looking amazing!

Thanks @Panquesito7 for your time in reviewing this.
I have learnt a lot about documentation and code structure working with you. It was a great experience for me because It is my first time doing open source contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants