fix: [generic + sort] All ready for generics #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rwara99/Go into feature/generics-interfaces
cclauss
approved these changes
Mar 26, 2022
siriak
approved these changes
Mar 26, 2022
This was referenced Mar 27, 2022
quaeler
reviewed
May 30, 2022
| func Count(data []int) []int { | ||
| import "github.com/TheAlgorithms/Go/constraints" | ||
|
|
||
| func Count[T constraints.Number](data []int) []int { |
There was a problem hiding this comment.
why isn't this
func Count[T constraints.Number](data []T) []T {
?
There was a problem hiding this comment.
Primarily because I missed it... Feel free to open a PR to rectify it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of Generics in Go. A relatively simple PR to include some examples use cases of Generics in sort. Was not able to actually convert some of the sort algorithms due to their intrinsic dependence on type
int.