feat: add cycle sort algorithm #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalAditya
requested review from
siriak,
raklaptudirm,
tjgurwara99 and
yanglbme
as code owners
tjgurwara99
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Good comments in the code! I usually always write to people to explain the question of "why you're doing" in comments instead of "what you're doing" since the latter can be explained by the code itself. You seem to have a correct balance (except for a few places).
tjgurwara99
reviewed
Apr 28, 2023
tjgurwara99
approved these changes
Apr 28, 2023
|
@siriak @raklaptudirm since I added a commit to the PR, could you both review this as well 🙏🏼 |
raklaptudirm
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the cycle sort algorithm. Link for reference: https://en.wikipedia.org/wiki/Cycle_sort
Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - GoDoc guidelines
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
I acknowledge that all my contributions will be made under the project's license.