Skip to content

Travis CI: Fix build validation issues, add Xlint options #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2020
Merged

Travis CI: Fix build validation issues, add Xlint options #2047

merged 2 commits into from
Nov 26, 2020

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Nov 25, 2020 •
edited
Loading

Screen Shot 2020-11-25 at 10 17 20

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Improve testing

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
Copy link
Member Author

cclauss commented Nov 25, 2020

Should these issues be addressed? https://travis-ci.com/github/TheAlgorithms/Java/builds/204123272#L195

@cclauss cclauss mentioned this pull request Nov 25, 2020
Closed
realDuYuanChao
realDuYuanChao approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@realDuYuanChao realDuYuanChao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realDuYuanChao realDuYuanChao merged commit c85223b into master Nov 26, 2020
@cclauss cclauss deleted the Travis-CI-Fix-build-validation-issues,-add-Xlint-options branch November 26, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realDuYuanChao realDuYuanChao realDuYuanChao approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @realDuYuanChao