Skip to content

style: include ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD #5129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Apr 29, 2024

This PR includes ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD SpotBugs rule.

Related to #5122.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.54%. Comparing base (5d00889) to head (517f912).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5129      +/-   ##
============================================
- Coverage     37.56%   37.54%   -0.02%     
+ Complexity     2364     2363       -1     
============================================
  Files           517      517              
  Lines         15605    15605              
  Branches       2965     2965              
============================================
- Hits           5862     5859       -3     
- Misses         9457     9458       +1     
- Partials        286      288       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review April 29, 2024 19:09
@vil02 vil02 enabled auto-merge (squash) April 29, 2024 19:10
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vil02 vil02 merged commit dc47e0a into TheAlgorithms:master May 5, 2024
4 checks passed
@vil02 vil02 deleted the include_ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD branch May 5, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants