Skip to content

style: include IM_AVERAGE_COMPUTATION_COULD_OVERFLOW #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions spotbugs-exclude.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@
<Match>
<Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" />
</Match>
<Match>
<Bug pattern="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW" />
</Match>
<Match>
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
</Match>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ private static int binarySearchBetween(int[] t, int end, int key) {
return end + 1;
}
while (left < right - 1) {
int middle = (left + right) / 2;
final int middle = (left + right) >>> 1;
if (t[middle] < key) {
left = middle;
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static void alteredBinSearch(int[] nums, int key, int left, int right, in
if (left > right) {
return;
}
int mid = (left + right) / 2;
int mid = (left + right) >>> 1;
if (nums[mid] > key) {
alteredBinSearch(nums, key, left, mid - 1, range, goLeft);
} else if (nums[mid] < key) {
Expand All @@ -52,7 +52,7 @@ public static void alteredBinSearch(int[] nums, int key, int left, int right, in
// of 'key'
public static void alteredBinSearchIter(int[] nums, int key, int left, int right, int[] range, boolean goLeft) {
while (left <= right) {
int mid = (left + right) / 2;
final int mid = (left + right) >>> 1;
if (nums[mid] > key) {
right = mid - 1;
} else if (nums[mid] < key) {
Expand Down Expand Up @@ -84,7 +84,7 @@ public static int getCountLessThan(int[] nums, int key) {
public static int getLessThan(int[] nums, int key, int left, int right) {
int count = 0;
while (left <= right) {
int mid = (left + right) / 2;
final int mid = (left + right) >>> 1;
if (nums[mid] > key) {
right = mid - 1;
} else if (nums[mid] <= key) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public int[] binaryInsertSort(int[] array) {
int high = i - 1;

while (low <= high) {
int mid = (low + high) / 2;
final int mid = (low + high) >>> 1;
if (temp < array[mid]) {
high = mid - 1;
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/thealgorithms/sorts/SlowSort.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ private <T extends Comparable<T>> void sort(T[] array, int i, int j) {
if (SortUtils.greaterOrEqual(i, j)) {
return;
}
int m = (i + j) / 2;
final int m = (i + j) >>> 1;
sort(array, i, m);
sort(array, m + 1, j);
if (SortUtils.less(array[j], array[m])) {
Expand Down