Skip to content

fix: handle Null Dereference in RomanToInteger #5461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 23, 2024

Continuation of #5456.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.21%. Comparing base (b849cbb) to head (06b9388).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5461      +/-   ##
============================================
+ Coverage     52.17%   52.21%   +0.03%     
- Complexity     3245     3246       +1     
============================================
  Files           524      524              
  Lines         15158    15156       -2     
  Branches       2881     2881              
============================================
+ Hits           7909     7913       +4     
+ Misses         6924     6919       -5     
+ Partials        325      324       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review September 23, 2024 07:29
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 18f6f8c into TheAlgorithms:master Sep 23, 2024
6 checks passed
@vil02 vil02 deleted the NULLPTR_DEREFERENCE_in_RomanToInteger branch September 23, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants