Skip to content

feat: Add IPv6Converter new algorithm with Junit tests #5783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 26, 2024

Conversation

Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 13, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (009c2b3) to head (19e1d0b).

Files with missing lines Patch % Lines
...a/com/thealgorithms/conversions/IPv6Converter.java 70.37% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5783   +/-   ##
=========================================
  Coverage     70.16%   70.16%           
- Complexity     4754     4761    +7     
=========================================
  Files           634      635    +1     
  Lines         17295    17322   +27     
  Branches       3327     3333    +6     
=========================================
+ Hits          12135    12154   +19     
- Misses         4704     4708    +4     
- Partials        456      460    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hardvan Hardvan marked this pull request as ready for review October 13, 2024 15:18
siriak
siriak previously approved these changes Oct 15, 2024
@siriak
Copy link
Member

siriak commented Oct 15, 2024

Please fix PR checks

@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 16, 2024

I have fixed the PR checks.

@Hardvan Hardvan requested a review from siriak October 16, 2024 03:04
@siriak siriak enabled auto-merge (squash) October 26, 2024 08:45
@siriak siriak merged commit 6fc53ec into TheAlgorithms:master Oct 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants