Skip to content

feat: add midpoint ellipse algorithm #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2024
Merged

feat: add midpoint ellipse algorithm #5870

merged 6 commits into from
Oct 26, 2024

Conversation

saahil-mahato
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (e4ef072) to head (2a3898f).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5870      +/-   ##
============================================
+ Coverage     70.35%   70.42%   +0.07%     
- Complexity     4781     4794      +13     
============================================
  Files           640      641       +1     
  Lines         17342    17390      +48     
  Branches       3337     3346       +9     
============================================
+ Hits          12201    12247      +46     
- Misses         4680     4681       +1     
- Partials        461      462       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saahil-mahato saahil-mahato marked this pull request as ready for review October 16, 2024 07:17
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 26, 2024 09:15
@siriak siriak merged commit 70adf6f into TheAlgorithms:master Oct 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants