Add combinations #1015
Merged
Add combinations #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Jul 14, 2019
|
|
||
|
|
||
| def generate_all_combinations(n: int, k: int) -> [[int]]: | ||
| result = [] |
There was a problem hiding this comment.
Please insert this function docstring here:
def generate_all_combinations(n: int, k: int) -> [[int]]:
"""
>>> generate_all_combinations(n=4, k=2)
1 2
1 3
1 4
2 3
2 4
3 4
"""
backtracking/all_combinations.py
Outdated
| n = 4 | ||
| k = 2 | ||
| total_list = generate_all_combinations(n, k) | ||
| print_all_state(total_list) |
There was a problem hiding this comment.
Please put these four lines under a if __name__ == '__main__':
if __name__ == '__main__':
n = 4
k = 2
total_list = generate_all_combinations(n, k)
print_all_state(total_list)Or just replace the four lines with:
if __name__ == "__main__":
import doctest
doctest.testmod()This should not change the functionality of your script but it should give it a new superpower:
- python3 -m doctest -v backtracking/all_combinations.py
|
It would be cool to think up more helpful variable names than n and k. |
|
Is this ready to be merged or are you still working on it? |
|
Is this ready to be merged or are you still working on it? |
|
It's ready to be merged. |
|
import itertools ; print(list(itertools.combinations(range(1, 5), 2))) |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Update Bucket Sort time complexity analysis * Add combinations * Adding doctest * Fix doctest problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return all possible combinations of k numbers out of 1 ... n.