New version with english comments #12762
Conversation
J'ai nourri ce programme en ajoutant une porte And à n entrées.
for more information, see https://pre-commit.ci
Commentaires en anglais
for more information, see https://pre-commit.ci
This add is about algorithms' complexity. The goal is to be able, for a given algorithm, knowing primary operations and their execution time, to predict how long it will take
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
enhancement
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # you if your code or solution is efficient or not ; it helps you not to fall trying to run such a code. | ||
|
|
||
|
|
||
| def calc(operations: dict) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/time_algo_exec.py, please provide doctest for the function calc
algorithms-keeper
bot
added
awaiting reviews
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # or solution is efficient or not ; it helps you not to fall trying to run such a code. | ||
|
|
||
|
|
||
| def calc(operations: dict) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/time_algo_exec.py, please provide doctest for the function calc
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # or solution is efficient or not ; it helps you not to fall trying to run such a code. | ||
|
|
||
|
|
||
| def calc(operations: dict) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/time_algo_exec.py, please provide doctest for the function calc
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # efficient or not ; it helps you not to fall trying to run such a code. | ||
|
|
||
|
|
||
| def calc(operations: dict) -> float: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file other/time_algo_exec.py, please provide doctest for the function calc
There was a problem hiding this comment.
What doctest for calc function are you talking about?
algorithms-keeper
bot
removed
the
tests are failing
Fixing doctest problem
algorithms-keeper
bot
removed
the
require tests
algorithms-keeper
bot
removed
the
tests are failing
Describe your change:
Checklist: