Skip to content

Change_method_name #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mrcloma
Copy link

@mrcloma mrcloma commented May 3, 2020

Fixes #1926
Change method name because it's the same name as an attribute.

@cclauss
Copy link
Member

cclauss commented May 3, 2020

Why does this pull request have a diff that changes every single line in the file? Is it line endings?

@mrcloma
Copy link
Author

mrcloma commented May 3, 2020

Maybe I made a mistake but at first only line 46 was changed.

@mrcloma
Copy link
Author

mrcloma commented May 3, 2020

Yes, its the line endings probably.

@cclauss
Copy link
Member

cclauss commented May 6, 2020

Fixed in #1943

@cclauss cclauss closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same name for an attribute and a function
2 participants