Skip to content

change method name from front to get_front (#1943) #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 408 commits into from
Closed

change method name from front to get_front (#1943) #1949

wants to merge 408 commits into from

Conversation

8ss
Copy link

@8ss 8ss commented May 6, 2020

Co-authored-by: “Vipul <“[email protected]”>

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

chttrjeankr and others added 30 commits October 22, 2019 18:02
@chttrjeankr @cclauss
Project Euler problems 06, 20 (#1419)
11e2207 
* added sol3.py for problem_20

* added sol4.py for problem_06
@chttrjeankr @cclauss
psf/black code formatting (#1421)
7592cba 
* added sol3.py for problem_20

* added sol4.py for problem_06

* ran `black .` on `\Python`
@matheustguimaraes @cclauss
Add algorithm to rotate images (#1420)
5fd868c 
* Add algorithm to rotate image

* Edit function to be compliant in Black and Flake8 formats

* Add type hints in get_rotation() and  enumerate() in loop
@poyea
Readability of CONTRIBUTING.md (#1422)
5683025 
* Readability of guidelines

* Update README.md
@chttrjeankr @cclauss
introduced shuffled_shift_cipher.py in /ciphers (#1424)
d477a4d 
* introduced shuffled_shift_cipher.py in /ciphers

* made requested changes

* introduced doctests, type hints
removed __make_one_digit()

* test_end_to_end() inserted

* Make test_end_to_end() a test ;-)
@praisearts @cclauss
create simple binary search (#1430)
7b3d385 
* create simnple binary search

#A binary search implementation to test if a number is in a list of elements

* Add .py, format with psf/black, and add doctests
@codecalec @cclauss
Added determinate function (#1429)
0748313 
* Added determinate function

* Changed determinate function name

* Changed instance of .det() to .determinate()

* Added force_test() function

* Update tests.py
@codecalec @cclauss
Fixes in methods and tests in Linear Algebra (#1432)
ec85cc8 
* Fixes in methods and tests

* Renamed tests.py to test_linear_algebra.py

* removed force_test()

* Delete test_linear_algebra.py

* Format code with psf/black

* Rename tests.py to test_linear_algebra.py
@isaacgdo @cclauss
Add gaussian_elimination.py for solving linear systems (#1448)
03e9a75
@samarthsehgal97 @cclauss
Update treap.py (#1455)
a2a3ca6
@bizzfitch @cclauss
Adding deterministic miller rabin primality test (#1453)
182062d 
* Adding deterministic miller rabin primality test

* Moved to ciphers directory and renamed for clarity. Changed docstring to add test
@samarthsehgal97 @cclauss
Update aho-corasick.py (#1457)
3ea0992
@chttrjeankr @cclauss
minor changes in format of DIRECTORY.md (#1461)
a61b05b
@prathmesh1199 @cclauss
Added binomial coefficient (#1467)
a57809a 
* Added binomial coefficient

* Format code with psf/black and add a doctest
@ArjunwadkarAjay @cclauss
Some grammatical and spelling corrections (#1475)
bc52aa6
@suadjelili @cclauss
added solution 4 for problem_20 (#1476)
a7078d7
@orkunincili @cclauss
Python program that listing top 'n' movie in imdb (#1477)
8b52e44 
* Python program that listing top 'n' movie in imdb

* Update get_imdbtop.py
@suadjelili @cclauss
added solution 3 for problem_25 (#1478)
39c40e7 
* added solution 4 for problem_20

* added solution 3 for problem_25
@Deekshaesha @cclauss
finding max (#1488)
8a5b1ab 
* Update find_max.py

* Update find_max.py

* Format with psf/black and add doctests
@arjun1299 @cclauss
Hard coded inputs to mixed_keyword cypher (#1500)
e36fe34 
* Update morse_code_implementation.py

* Delete porta_cipher.py

* Update mixed_keyword_cypher.py

* Mixed keyword cypher added

* issue with mixed keyword fixed

* no math included

* hardcoded inputs

* porta cypher added

* porta cypher added

* commented in mixed keyword according to contrib.md
@cclauss
Add Travis_CI_tests_are_failing.md (#1499)
bf50ea0 
* Add Travis_CI_tests_are_failing.md

* Update Travis_CI_tests_are_failing.md
@realDuYuanChao @cclauss
rename and add doctest (#1501)
3fc276c
@poyea @cclauss
Improve doctest and comment for maximum sub-array problem (#1503)
1da1ab0 
* Doctest and comment for maximum sub-array problem

More examples and description for max_sub_array.py

* Update max_sub_array.py

* Update max_sub_array.py

* Fix doctest
@phileasme @cclauss
Page replacement algorithm, LRU (#871)
3ada8bb 
* Page replacement algorithm, LRU

* small rectifications

* Rename paging/LRU.py to other/least_recently_used.py
@dimgrichr @cclauss
Addition of Secant Method (#876)
f8a30b4 
* Add files via upload

* Update secant_method.py

* Remove unused import

* Remove unused import
@DevilLord9967 @cclauss
Create GAN.py (#1445)
4f86f58 
* Create GAN.py

* gan update

* Delete train-labels-idx1-ubyte.gz

* Update GAN.py

* Update GAN.py

* Delete GAN.py

* Create gan.py

* Update gan.py

* input_data import file
@Kumar-Nishchay @poyea
Update dictionary.txt (#1507)
e463c0b 
Added a new word Microfinance. This is one of the recently added word in oxford dictionary
@percy07 @cclauss
Update greatest_common_divisor.py (#1513)
e3d4d2b 
Add Doctests.
@percy07 @cclauss
Update palindrome.py (#1509)
1ed47ad 
* Update palindrome.py

Add Doctests.

* Use test_data to drive the testing
@janithwanni @cclauss
✅ added tests for Perceptron in Neural Networks (#1506)
dfea6f3 
* ✅ added tests for Perceptron in Neural Networks

* Space

* Format code with psf/black
cclauss and others added 25 commits April 23, 2020 11:57
@cclauss
Add cellular_automata directory (#1902)
b560b76 
Related to #1613 (comment) @8Dion8 Your review please.  Once this land, this directory would be a great place for you to add your work.
@Prince326
Update linear_search.py (#1906)
58271c5
@SandersLin
Fix typo in Project Euler sol1.py (#1875)
e5dd2b1
@l3str4nge @cclauss
Added sepia tone (#1877)
5933cd4 
* Add sepia tone

* Add unit test

* technic --> technique

* Update digital_image_processing/sepia.py

Co-Authored-By: Christian Clauss <[email protected]>

* Update digital_image_processing/sepia.py

Co-Authored-By: Christian Clauss <[email protected]>

* Fixed errors after commit changes

* Fixed errors

Co-authored-by: Christian Clauss <[email protected]>
@8Dion8 @cclauss
Create one_dimensional.py (#1905)
0ef9dd3 
* Create one_dimensional.py

* Update cellular_automata/one_dimensional.py

Co-Authored-By: Christian Clauss <[email protected]>

* Update cellular_automata/one_dimensional.py

Co-Authored-By: Christian Clauss <[email protected]>

* Update one_dimensional.py

Moved import to the top so that the type Image gets recognized

* Update one_dimensional.py

* Update cellular_automata/one_dimensional.py

* Update cellular_automata/one_dimensional.py

* Update one_dimensional.py

* Update one_dimensional.py

* Update one_dimensional.py

Co-authored-by: Christian Clauss <[email protected]>
@cclauss
Blacken one_dimensional.py (#1911)
8cb957f 
* Blacken one_dimensional.py

* updating DIRECTORY.md

* Travis CI: Upgrade to Ubuntu 20.04 LTS Focal

Ubuntu 20.04 LTS (Focal Fossa) https://releases.ubuntu.com/focal

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@LethargicLeprechaun @cclauss
Added A1Z26 Cipher (#1914)
fbc038d 
* A1Z26 Cipher

* A1Z26 Cipher

* Added type hints

* Added Doctests

* removed tabs, spaces instead

* corrected doctest

* corrected doctest

* info URLs added

* Condensed decode to one line

* Condensed encode function to a single line

* Nice one!

Co-authored-by: Christian Clauss <[email protected]>
@l3str4nge @cclauss
Added Burkes dithering algorithm. (#1916)
3d0680e 
* Added Burkes dithering algorithm

* Added unit tests for burkes algorithm

* Fix burkes algorithm

* Added some additional information

* Fixed CI tests

* Update digital_image_processing/dithering/burkes.py

Co-Authored-By: Christian Clauss <[email protected]>

* Update digital_image_processing/dithering/burkes.py

Co-Authored-By: Christian Clauss <[email protected]>

* Update digital_image_processing/dithering/burkes.py

Co-Authored-By: Christian Clauss <[email protected]>

* Propogate the += and add a doctest

* Fix doctest

* @staticmethod --> @ classmethod to ease testing

* def test_burkes(file_path):

* Fix for mypy checks

* Fix variable order in get_greyscale

* Fix get_greyscale method

* Fix get_greyscale method

* 3.753

Co-authored-by: Christian Clauss <[email protected]>
@cclauss
Fix invalid escape sequence in binary_search_tree.py (#1920)
1ad78b2 
* Fix invalid escape sequence in binary_search_tree.py

data_structures/binary_tree/binary_search_tree.py:156
  /home/travis/build/TheAlgorithms/Python/data_structures/binary_tree/binary_search_tree.py:156: DeprecationWarning: invalid escape sequence \

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@CSenshi @cclauss
Graph coloring (#1921)
b01e5b7 
* add skeleton code

* add doctests

* add mainc function pseudo code and tests (ToDo: write Implementation)

* typo fixes

* implement algorithm

* add type checking

* add wikipedia link

* typo fix

* update range syntax

Co-authored-by: Christian Clauss <[email protected]>

* change indexed iteration checking to any()

Co-authored-by: Christian Clauss <[email protected]>

* fix: swap import and documentation sections

* fix: change return none to return empty list

* remove unnecessary import (Union)

* change: remove returning boolean indicating problem was solved or not

* remove unnecessary import (Tuple)

Co-authored-by: Christian Clauss <[email protected]>
@SandersLin @poyea @cclauss
Add shortest path by BFS (#1870)
308505f 
* Create breadth_first_search_shortest_path.py

* updating DIRECTORY.md

* Reduce side effect of `shortest_path`

For the sake of future testing and documentation -

* fixup! Format Python code with psf/black push

* Fix typo `separately`

* Change to get() from dictionary

Co-Authored-By: Christian Clauss <[email protected]>

* Move graph to the top

* fixup! Format Python code with psf/black push

* Add doctest for shortest path

* Add doctest for BFS

* fixup! Format Python code with psf/black push

* Add typings for breadth_first_search_shortest_path

* fixup! Format Python code with psf/black push

* Remove assert from doctests

* Add blank line to doctest

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: John Law <[email protected]>
@QuantumNovice
Changed the deprecated np.matrix to np.ndarray (#1923)
bcaa88b
@cclauss
Wrap lines that go beyond GitHub Editor (#1925)
6acd7fb 
* Wrap lines that go beyond GiHub Editor

* flake8 --count --select=E501 --max-line-length=127

* updating DIRECTORY.md

* Update strassen_matrix_multiplication.py

* fixup! Format Python code with psf/black push

* Update decision_tree.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@lkdmttg7 @poyea @cclauss
Update stale comment (#1924)
d62cc35 
* Update close comment

* Update stale.yml

* Multiline strings in yaml files

https://yaml-multiline.info/

Co-authored-by: John Law <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
@CSenshi @cclauss
Hamiltonian Cycle (#1930)
a859934 
* add skeleton code

* add doctests

* add tests for util function + implement wrapper

* full implementation

* add ability to add starting verex for algorithm

* add static type checking

* add doc tests to validation method

* bug fix: doctests expected failing

* Update hamiltonian_cycle.py

* Update hamiltonian_cycle.py

Co-authored-by: Christian Clauss <[email protected]>
@QuantumNovice @cclauss
support_vector_machines.py increase error tolerance to suppress conve…
9bb57fb 
…rgence warnings (#1929)

* Update support_vector_machines.py

* Update support_vector_machines.py

Co-authored-by: Christian Clauss <[email protected]>
@lanzhiwang
enhanced segment tree implementation and more pythonic (#1715)
853741e 
* enhanced segment tree implementation and more pythonic

enhanced segment tree implementation and more pythonic

* add doctests for segment tree

* add type annotations

* unified processing sum min max segment tre

* delete source encoding in segment tree

* use a generator function instead of returning

* add doctests for methods

* add doctests for methods

* add doctests

* fix doctest

* fix doctest

* fix doctest

* fix function parameter and fix determine conditions
Check if a item exist in stack or not (#1931)
b6fcee3 
* Check if a item exist in stack or not

* implemented __contains__ method in stack

* made changes in __contains__
@cclauss
added method for checking armstrong number (#1936)
f80ffe1 
* added method for checking armstrong number

* Update comment

Co-authored-by: Christian Clauss <[email protected]>
@shuklalok @cclauss
Solution for Euler Problem 26 (#1939)
9b2d65b 
* Solution for Euler Problem 26

* Update project_euler/problem_26/sol1.py

typo error fix.

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_26/sol1.py

typo error fix

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_26/sol1.py

ok to remove, this comes from Pycharm automatically when docstring is added.

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_26/sol1.py

ok to remove.

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_26/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_26/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* Update project_euler/problem_26/sol1.py

Co-authored-by: Christian Clauss <[email protected]>

* now_divide = now_divide * 10 % divide_by_number

Co-authored-by: Christian Clauss <[email protected]>
@cclauss
Fix psf/black issues than fail the build (#1935)
d1b2576 
* Fix psf/black issues than fail the build

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@AnupKumarPanwar
Delete FUNDING.yml
540023e
@SandersLin @itsvinayak @poyea
Create sol2.py (#1876)
1e84aab 
* Create sol2.py

* updating DIRECTORY.md

* Update DIRECTORY.md

* updating DIRECTORY.md

* Update sol2.py

* Update DIRECTORY.md

* updating DIRECTORY.md

* Improve docstrings

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: vinayak <[email protected]>
Co-authored-by: John Law <[email protected]>
@cclauss
Deal with maps (#1945)
08c8bb5 
* Deal with maps

Try with the search term "pizza" to see why this was done in #1932

* fixup! Format Python code with psf/black push

* Update armstrong_numbers.py

* updating DIRECTORY.md

* Update crawl_google_results.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@scriptdruid
change method name from front to get_front (#1943)
3d4ccc3 
Co-authored-by: “Vipul <“[email protected]”>
@itsvinayak
Copy link
Member

@zumplxs this issue is already solved

@itsvinayak itsvinayak requested a review from cclauss May 6, 2020 08:19
@cclauss
Copy link
Member

cclauss commented May 6, 2020

This PR needs a serious rebase or it should be closed.

@itsvinayak
Copy link
Member

@cclauss this issue is already solved in #1943 , let's close it

@cclauss cclauss closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.