Skip to content

Wiggle sort #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 25, 2020
Merged

Wiggle sort #2419

merged 11 commits into from
Sep 25, 2020

Conversation

grochedix
Copy link
Contributor

Describe your change:

Improved wiggle_sort.py, mainly with type hinting and doctests.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

l3str4nge
l3str4nge requested changes Sep 20, 2020
View reviewed changes
sorts/wiggle_sort.py Outdated
def wiggle_sort(nums):
"""Perform Wiggle Sort."""
for i in range(len(nums)):
def wiggle_sort(nums: list):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add return hint. Please also provide doctest with float numbers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@grochedix grochedix requested a review from l3str4nge September 24, 2020 16:49
@cclauss
Copy link
Member

cclauss commented Sep 24, 2020

@mateuszz0000 If this is ready to merge then please approve and then click Squash & merge.

@l3str4nge l3str4nge merged commit f564c9d into TheAlgorithms:master Sep 25, 2020
@cclauss
Copy link
Member

cclauss commented Sep 25, 2020

@mateuszz0000 Thanks. Are there any other open PRs that you think should be landed?

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@grochedix @stokhos
Wiggle sort (TheAlgorithms#2419)
b0a4507 
* wiggle sort : type hint + doctest

* fixed function name in docstring

* correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grochedix @cclauss @l3str4nge