Financials #5585
Merged
Financials #5585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
awaiting reviews
ghost
reviewed
Oct 24, 2021
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
removed
the
require type hints
Bhargavishnu
suggested changes
Oct 24, 2021
cclauss
reviewed
Oct 24, 2021
financials/interest.py
Outdated
| >>> simple_interest(18000,0.06,3) | ||
| 3240.0 | ||
| """ | ||
| result = principle * daily_interest_rate * number_of_days_between_payments |
There was a problem hiding this comment.
Suggested change
| result = principle * daily_interest_rate * number_of_days_between_payments | |
| return principle * daily_interest_rate * number_of_days_between_payments |
cclauss
reviewed
Oct 24, 2021
cclauss
reviewed
Oct 24, 2021
financials/interest.py
Outdated
| def simple_interest(principle:float, daily_interest_rate:float, number_of_days_between_payments:int) -> float: | ||
| """ | ||
| >>> simple_interest(18000,0.06,3) | ||
| 3240.0 |
There was a problem hiding this comment.
Add tests dealing with zero principle, negative principle, zero interest rate, negative interest rate, zero days, negative days, etc.
There was a problem hiding this comment.
@cclauss done
Bhargavishnu
approved these changes
Oct 25, 2021
ghost
added
tests are failing
cclauss
approved these changes
Oct 26, 2021
cclauss
added
the
hacktoberfest-accepted
|
@dhruvmanila How do we fix the single blank line in |
poyea
reviewed
Oct 26, 2021
|
|
||
|
|
||
| def compound_interest( | ||
| principle: float, |
There was a problem hiding this comment.
I think it's
Suggested change
| principle: float, | |
| principal: float, |
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Both URLs say that you are correct --> #5614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
This Pull request brings calculations for financial. Also creates a 'about file' to make an intro for begginers.
Checklist:
Fixes: #{$ISSUE_NO}.