Skip to content

fix: no implicit optional #7984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix: no implicit optional #7984

merged 1 commit into from
Nov 15, 2022

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Nov 15, 2022 •
edited
Loading

https://mypy-lang.blogspot.com/2022/11/mypy-0990-released.html

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass enhancement This PR modified some existing files labels Nov 15, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Nov 15, 2022
cclauss
cclauss requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!!!

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Nov 15, 2022
@cclauss cclauss self-requested a review November 15, 2022 13:54
@algorithms-keeper algorithms-keeper bot removed the awaiting changes A maintainer has requested changes to this PR label Nov 15, 2022
@cclauss cclauss merged commit 3bf86b9 into TheAlgorithms:master Nov 15, 2022
@dhruvmanila dhruvmanila deleted the fix/implicit-optional branch November 15, 2022 16:27
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@dhruvmanila @Cjkjvfnby
fix: no implicit optional (TheAlgorithms#7984)
bbb3d77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhruvmanila @cclauss @CaedenPH