Update 3n+1.py #996
Merged
Update 3n+1.py #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made variable names more meaningful and removed nested functions.
cclauss
reviewed
Jul 10, 2019
|
What should happen on a negative number? a floating point number? def n31(initial_number):
"""
>>> n31(43) # doctest: +ELLIPSIS
([43, ...], 29)
""" |
|
Good catch! Added argument validation and type hints. |
cclauss
reviewed
Jul 11, 2019
maths/3n+1.py
Outdated
| @@ -15,10 +21,10 @@ def n31(a): | |||
| a = 3*a +1 | |||
| counter += 1 | |||
| path += [a] | |||
| return path , counter | |||
| return path, counter + 1 | |||
There was a problem hiding this comment.
Would it also work to return path, len(path) ?
There was a problem hiding this comment.
Yes, that is more elegant, thanks!
cclauss
reviewed
Jul 11, 2019
maths/3n+1.py
Outdated
| """ | ||
| Returns Collatz sequence of number a | ||
|
|
||
| Returns Collatz sequence of a number |
There was a problem hiding this comment.
This comment says that we are only returning the sequence but we are returning the sequence and its length.
There was a problem hiding this comment.
updated docstring
cclauss
reviewed
Jul 11, 2019
| def main(): | ||
| num = 4 | ||
| path , length = n31(num) | ||
| print("The Collatz sequence of {0} took {1} steps. \nPath: {2}".format(num,length, path)) |
There was a problem hiding this comment.
You can drop the 0, 1, and 2 here and drop the 0 in the raise statements above.
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Update 3n+1.py Made variable names more meaningful and removed nested functions. * Update 3n+1.py * Update 3n+1.py * Update 3n+1.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made variable names more meaningful and removed nested functions.