fix: Make xor output Vec<u8> #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String is documented as utf8 encoded text. This can contain multibytes. The cast of char to u8 is lossy. test_multi_byte fails before the API change. The other new tests also test common encoding issues. The don't fail on the old code, but the intermediaries are invalid.
siriak
reviewed
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String is documented as utf8 encoded text.
This can contain multibytes. The cast of char to u8 is lossy.
test_multi_byte fails before the API change.
The other new tests also test common encoding issues.
The don't fail on the old code, but the intermediaries are invalid.
This could also be done with e.g.
Box<[u8]>, but String is growable, soVec<u8>should be fine.This changes the API, but since the old one necessarily violates documented type properties, IMO it needs to be done.