-
-
Notifications
You must be signed in to change notification settings - Fork 410
feat: Added Double Factorial Iterative Implementation #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Double Factorial Iterative Implementation #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise fine, but unfortunately not really algorithmically interesting...
Yeah, that is indeed true. This code does not really have anything particularly interesting going for it. The sole reason I added this is so that the TypeScript implementations are available for more algorithms and it was the first one which I saw which didn't have an implementation. |
Could you please atleast leave a reply @appgurueu ...? |
Umm, a response or a reply would be highly appreciated |
Sorry for the late reply. I am pretty indecisive on this, which unfortunately lead to me postponing & forgetting about it. Well, nothing has changed; I still think this is relatively straightforward, about as interesting as the factorial implementation - it may be warranted on these grounds, also considering that it has some applications in combinatorics. I'm fairly neutral on this; I'm not opposed to merging this. @raklaptudirm thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation seems to be of good quality, so I approve of its merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to resolve a merge conflict, so you'll have to reapprove @raklaptudirm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 96.98% 97.00% +0.01%
==========================================
Files 97 98 +1
Lines 1793 1800 +7
Branches 345 346 +1
==========================================
+ Hits 1739 1746 +7
Misses 54 54 ☔ View full report in Codecov by Sentry. |
This pull request aims to add the iterative implementation of double factorial in TypeScript
Here's the entry I aim to add an implementation to: https://the-algorithms.com/algorithm/double-factorial-iterative