Skip to content

Add and run prettier #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Add and run prettier #234

merged 3 commits into from
Mar 18, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Mar 17, 2024

This monster PR consists of two three steps/commits:

  • adds and configures prettier in a similar way as in JavaScript,
  • formats the code by running the command npm run style,
  • adds a step, checking the formatting, into the CI.

When this will be merged, I will create another PR modifying the CI in such a way, that the formatting is checked (I guess @Panquesito7 will be needed to merge such PR).

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 95.97015% with 54 lines in your changes missing coverage. Please review.

Project coverage is 96.84%. Comparing base (c5b12db) to head (d137e41).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
data_structures/list/singly_linked_list.ts 79.71% 14 Missing ⚠️
data_structures/list/doubly_linked_list.ts 91.52% 10 Missing ⚠️
data_structures/queue/circular_queue.ts 84.09% 7 Missing ⚠️
data_structures/tree/binary_search_tree.ts 87.23% 6 Missing ⚠️
data_structures/stack/linked_list_stack.ts 75.00% 5 Missing ⚠️
search/interpolation_search.ts 82.35% 3 Missing ⚠️
data_structures/heap/heap.ts 97.05% 2 Missing ⚠️
data_structures/map/hash_map.ts 97.56% 2 Missing ⚠️
maths/fibonacci.ts 94.44% 1 Missing ⚠️
maths/hamming_distance.ts 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   97.00%   96.84%   -0.16%     
==========================================
  Files          98       98              
  Lines        1800     1838      +38     
  Branches      346      348       +2     
==========================================
+ Hits         1746     1780      +34     
- Misses         54       58       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review March 17, 2024 20:39
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a CI for testing proper styling in this pull request too.

@vil02 vil02 requested a review from Panquesito7 as a code owner March 18, 2024 08:03
@vil02 vil02 requested a review from raklaptudirm March 18, 2024 10:04
@raklaptudirm raklaptudirm merged commit c2d7aa6 into TheAlgorithms:master Mar 18, 2024
@vil02 vil02 deleted the add_prettier branch March 18, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants