Skip to content

Reorganize file structure and tests to reduce context issues for AI #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 21, 2025

Conversation

Tiberriver256
Copy link
Owner

@Tiberriver256 Tiberriver256 commented Mar 19, 2025

The bots were struggling...

Attempting to co-locate tests and re-structure file/folders to screaming architecture to reduce cognitive load for the poor puppies

- Added missing newlines at the end of several configuration files (.eslintrc.json, .prettierrc, tsconfig.json, jest.config.js, jest.integration.config.js).
- Updated README.md to include additional environment variable setup instructions for Azure DevOps.
- Improved documentation across various files, ensuring clarity and completeness, particularly in authentication and project setup sections.
- Removed deprecated files and tests to streamline the codebase and improve maintainability.
- Updated test files to follow colocation patterns, improving organization and maintainability.
- Added tasks to fix specific test files by co-locating or moving individual tests to appropriate files.
- Enhanced error handling in authentication tests to provide clearer error messages for token acquisition failures.
- Updated mock implementations in tests to ensure accurate behavior and error handling for Azure DevOps API interactions.
- Added tests to handle non-Error objects in catch blocks for both listRepositories and listWorkItems functions, ensuring proper error messages are thrown.
- Updated existing tests to convert generic error messages into specific Azure DevOps error types, improving clarity and robustness in error handling.
- Refactored mock implementations in authentication tests to simulate various error scenarios, enhancing test coverage and reliability.
…rganization

- Deleted outdated test files including server-coverage.test.ts, server-client.test.ts, auth.test.ts, and server-auth.test.ts to streamline the codebase.
- Refactored existing tests to enhance clarity and maintainability, ensuring they follow updated patterns and practices.
- Improved error handling in authentication tests, ensuring comprehensive coverage for various authentication scenarios.
- Updated mock implementations to accurately simulate Azure DevOps API interactions, enhancing test reliability.
This PR completes the test reorganization task by moving tests to follow the co-location pattern, ensuring proper organization and maintainability of the codebase.
…chitecture" and "Vertical Slices"

This commit finalizes the restructuring of the codebase to emphasize business domains over technical layers, implementing a feature-based module organization. All tasks related to the refactor have been completed, including the migration of tests to co-locate with their respective implementations, enhancing clarity and maintainability. The old layer-based directories have been removed, and the new structure has been validated with passing tests across all features.
@Tiberriver256 Tiberriver256 changed the title Reorganize test structure to follow co-location pattern Reorganize file structure and tests to reduce context issues for AI Mar 19, 2025
…ication method

This commit simplifies the setup_env.sh script by removing the Personal Access Token (PAT) creation process, which included both automated and manual methods. The script now defaults to using Azure Identity for authentication, streamlining the setup process. Additionally, the .env file has been updated to reflect the new authentication method, enhancing clarity and maintainability.
@Tiberriver256 Tiberriver256 merged commit 8e9a3f9 into main Mar 21, 2025
1 check passed
@Tiberriver256 Tiberriver256 deleted the task-1.0-screaming-architecture branch March 21, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants