Skip to content

Relax from_pandas 'append' requirement for 'row_start_index' #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Relax from_pandas 'append' requirement for 'row_start_index' #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions tiledb/dataframe_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,7 @@ def _sparse_from_dtypes(dtypes, sparse=None):
return sparse if sparse is not None else False


def create_dims(
df,
index_dims,
tile=None,
full_domain=False,
filters=None,
):
def create_dims(df, index_dims, tile=None, full_domain=False, filters=None):
per_dim_tile = isinstance(tile, dict)
if tile is not None:
tile_values = tile.values() if per_dim_tile else (tile,)
Expand Down Expand Up @@ -441,7 +435,8 @@ def from_pandas(uri, dataframe, **kwargs):
write = False
elif mode == "append":
create_array = False
if not sparse and row_start_idx is None:
schema = tiledb.ArraySchema.load(uri)
if not schema.sparse and row_start_idx is None:
raise TileDBError(
"Cannot append to dense array without 'row_start_idx'"
)
Expand Down